Lint verif testbenches as well now too!

angry-goose-initiative · Mar 28, 2024 · 42ebc22 · 42ebc22
1 parent 40a7f1c
commit 42ebc22
Show file tree

Hide file tree

Showing 9 changed files with 39 additions and 14 deletions.
diff --git a/.github/workflows/verible_pr_review.yml b/.github/workflows/verible_pr_review.yml
@@ -17,6 +17,7 @@ jobs:
           config_file: '.rules.verible_lint'
           paths: |
             ./rtl
+            ./verif/nonuvm
           exclude_paths: |
             ./rtl/fpga_wrapper
             ./rtl/legacy

diff --git a/.rules.verible_lint b/.rules.verible_lint
@@ -4,9 +4,12 @@
 -explicit-function-lifetime
 -unpacked-dimensions-range-ordering
 -case-missing-default
+-explicit-function-lifetime
+-explicit-task-lifetime
 +endif-comment
 +legacy-genvar-declaration
 +proper-parameter-declaration
++parameter-name-style=localparam_style:ALL_CAPS;parameter_style:ALL_CAPS
 +signal-name-style
 +suspicious-semicolon
 +mismatched-labels

diff --git a/lint/filelist.f b/lint/filelist.f
@@ -4,6 +4,12 @@
 #
 # Lint file list
 
+templates/systemverilog.sv
+
+####################################################################################################
+# RTL
+####################################################################################################
+
 rtl/common/fifo/fifo_0r0w.sv
 rtl/common/fifo/fifo_0r1w.sv
 rtl/common/fifo/fifo_1r1w.sv
@@ -41,3 +47,18 @@
 #We have to break convention here since we interact with AMD IP
 #TODO fine-grained waivers
 #rtl/fpga_wrapper/coraz7_top.sv
+
+####################################################################################################
+# Verif Non-UVM
+####################################################################################################
+
+verif/nonuvm/smoke_tb.sv
+
+verif/nonuvm/common/fifo/fifo_0r1w/fifo_0r1w_tb.sv
+
+verif/nonuvm/example/example_tb.sv
+
+verif/nonuvm/letc/core/letc_core_tb.sv
+verif/nonuvm/letc/core/alu/letc_core_alu_tb.sv
+verif/nonuvm/letc/core/branch_comparator/letc_core_branch_comparator_tb.sv
+verif/nonuvm/letc/core/stage_d/letc_core_stage_d_tb.sv
diff --git a/verif/nonuvm/common/fifo/fifo_0r1w/fifo_0r1w_tb.sv b/verif/nonuvm/common/fifo/fifo_0r1w/fifo_0r1w_tb.sv
@@ -1,11 +1,11 @@
 /**
  * File    fifo_0r1w_tb.sv
  * Brief   TODO
- * 
+ *
  * Copyright:
  *  Copyright (C) 2024 John Jekel
  * See the LICENSE file at the root of the project for licensing info.
- * 
+ *
  * TODO longer description
  *
 */
@@ -103,7 +103,7 @@ endtask
 
 task push(input logic [DWIDTH-1:0] data);
 begin
-    $display("Pushing %h", data);
+    $display("Pushing 'h%h", data);
 
     cb.i_push   <= 1'b1;
     cb.i_wdata  <= data;
@@ -112,7 +112,7 @@ endtask
 
 task pop();
 begin
-    $display("Popped %h", o_rdata);
+    $display("Popped 'h%h", o_rdata);
 
     cb.i_pop <= 1'b1;
 end
@@ -121,7 +121,7 @@ endtask
 task peak();
 begin
     assert(o_empty == 1'b0);
-    $display("Peaked %h", o_rdata);
+    $display("Peaked 'h%h", o_rdata);
 end
 endtask
 

diff --git a/verif/nonuvm/example/example_tb.sv b/verif/nonuvm/example/example_tb.sv
@@ -100,7 +100,7 @@ default clocking cb @(posedge i_clk);
     input  c3;
 
     input  counter_out;
-    
+
     output a4;
     input  b4;
 endclocking

diff --git a/verif/nonuvm/letc/core/alu/letc_core_alu_tb.sv b/verif/nonuvm/letc/core/alu/letc_core_alu_tb.sv
@@ -1,11 +1,11 @@
 /**
  * File    letc_core_alu_tb.sv
  * Brief   TODO
- * 
+ *
  * Copyright:
  *  Copyright (C) 2024 John Jekel
  * See the LICENSE file at the root of the project for licensing info.
- * 
+ *
  * TODO longer description
  *
 */
@@ -71,7 +71,7 @@ initial begin
     i_alu_operation = ALU_OP_SLT;
     #1;
     assert(o_alu_result == 32'h00000001);
-    
+
     //ALU_OP_SLTU
     i_alu_operands[0] = 32'hFFFFFFFF;//Now this is unsigned, so a large number
     i_alu_operands[1] = 32'h00001234;

diff --git a/verif/nonuvm/letc/core/branch_comparator/letc_core_branch_comparator_tb.sv b/verif/nonuvm/letc/core/branch_comparator/letc_core_branch_comparator_tb.sv
@@ -1,11 +1,11 @@
 /**
  * File    letc_core_branch_comparator_tb.sv
  * Brief   TODO
- * 
+ *
  * Copyright:
  *  Copyright (C) 2024 John Jekel
  * See the LICENSE file at the root of the project for licensing info.
- * 
+ *
  * TODO longer description
  *
 */

diff --git a/verif/nonuvm/letc/core/letc_core_tb.sv b/verif/nonuvm/letc/core/letc_core_tb.sv
@@ -1,11 +1,11 @@
 /**
  * File    letc_core_tb.sv
  * Brief   TODO
- * 
+ *
  * Copyright:
  *  Copyright (C) 2024 John Jekel
  * See the LICENSE file at the root of the project for licensing info.
- * 
+ *
  * TODO longer description
  *
 */

diff --git a/verif/nonuvm/smoke_tb.sv b/verif/nonuvm/smoke_tb.sv
@@ -1,7 +1,7 @@
 /**
  * File    smoke_tb.sv
  * Brief   Empty testbench for smoketests
- * 
+ *
  * Copyright:
  *  Copyright (C) 2024 John Jekel
  * See the LICENSE file at the root of the project for licensing info.