Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rosetta modifications #92

Merged
merged 8 commits into from
May 10, 2022
Merged

Rosetta modifications #92

merged 8 commits into from
May 10, 2022

Conversation

ngreenwald
Copy link
Member

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Updates the rosetta workflow for improved usability and speed.

How did you implement your changes

  1. Reorganized the notebook to emphasize changing only a single source channel at a time, rather than both Noodle and Au, as this was the approach I took.
  2. Add flat field correction for mass 39 to remove gradient across the image
  3. adds a helper function get_masses_from_channel_names to allow the user to specify channel names rather than masses
  4. Reorganize create_tiled_comparison to only read in data for one channel at a time, which results in significant speedup

Remaining issues
Once Hadeesha has finished testing his coefficients, we'll transition this notebook to evaluation purposes only. This will basically be a simple interface to making a stitched comparison of a pre- and post-rosetta. We'll hide the stuff about changing rosetta to emphasize that the defaults should work quite well for everyone

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ngreenwald ngreenwald merged commit 11b96db into main May 10, 2022
@ngreenwald ngreenwald deleted the rosetta_modifications branch May 10, 2022 16:31
@camisowers camisowers added the enhancement New feature or request label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants