Add ROI name prefix to tiled region FOV names #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On second thought, I don't think it's worth forcing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
In preparation for the tiled region interactive overlay, we need to address the underlying names of the FOVs generated for each tiled region. Right now, they are all in the form
R{m}C{n}, however this means thatR1C1will be indistinguishable from ROI1, ROI2, etc. Adding the ROI prefix will help disambiguate these (ex. if the ROI name isregion1, then the FOVs generated will be namedregion1_R1C1,region1_R2C1, etc.).Additionally, we need to standardize the use of
roias a variable identifier throughout the tiled regions functions. Right now, we usefovpretty generously. However, it will be easier to follow if we useroi.How did you implement your changes
See above.