Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cite TSAI in tiling notebooks, deprecating them #420

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Conversation

alex-l-kong
Copy link
Contributor

What is the purpose of this PR?

Closes #409. TSAI will be used for tiling MIBI runs from now on.

How did you implement your changes

Add citation to the tiling notebooks, informing users that functionality has been ported over there.

@alex-l-kong alex-l-kong self-assigned this Sep 7, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@alex-l-kong alex-l-kong requested review from ackagel and ag-tsai and removed request for ackagel September 7, 2023 18:41
@alex-l-kong
Copy link
Contributor Author

Worked with @ag-tsai on the citation, it's good to go now.

@ngreenwald ngreenwald merged commit 9cab3e0 into main Sep 14, 2023
@ngreenwald ngreenwald deleted the deprecate_tiler branch September 14, 2023 23:03
@srivarra srivarra added the documentation Improvements or additions to documentation label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deprecation warning to notebooks 2
4 participants