Turn off combined.csv file warnings for intermediate callbacks in watcher
#393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
camisowers
requested changes
Jul 21, 2023
camisowers
approved these changes
Jul 21, 2023
ngreenwald
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Closes #387. The new watcher setup means we'll be defaulting to using intermediate callbacks for plotting QC and MPH metrics. This means
combined.csvfiles, normally removed at the end of the watcher, now get removed after every FOV. The warning that gets thrown as a result can appear several times on cohorts with many FOVs, which we want to turn off in this situation.How did you implement your changes
Pass a
warn_overwriteflag to the relevant functions. Also include this check for QC combined file generation and overwriting.Remaining issues
Need testing on a live run, per the usual.