Adjust rosetta processing paths #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
camisowers
changed the title
camisowers
changed the title
srivarra
approved these changes
Jun 30, 2023
alex-l-kong
approved these changes
Jun 30, 2023
# Conflicts: # templates/1_set_up_toffy.ipynb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
While the current toffy pipeline was intended to be run completely on the MIBI CACs, the rosetta and normalization steps can require a bit of time to run and review the results. Many people will then choose to do this processing on their personal device, so we should adjust the rosetta processing intermediate files to be written to the D drive, where the other notebook output images are stored.
How did you implement your changes
Create a
Rosetta_processingdir in the D drive in notebook 1, which will contain therosetta_testingandrosetta_matricessubdirs formerly stored in the C drive.Remaining issues
Create the missing dirs on the Angelo Lab CACs to avoid errors if someone in lab does try to run notebook 4a on one of the machine computers.