Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update axes_size to axes_font_size in 3c notebook #343

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Conversation

alex-l-kong
Copy link
Contributor

@alex-l-kong alex-l-kong commented Apr 6, 2023

What is the purpose of this PR?

Closes #336. visualize_qc_metrics now takes axes_font_size instead of axes_size as a param. This change needs to be reflected in notebook 3c.

How did you implement your changes

Change the parameter name.

@alex-l-kong alex-l-kong self-assigned this Apr 6, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@alex-l-kong alex-l-kong requested a review from ngreenwald April 6, 2023 23:21
@ngreenwald ngreenwald merged commit 16f449d into main Apr 7, 2023
@ngreenwald ngreenwald deleted the axes_font_size branch April 7, 2023 03:54
@srivarra srivarra added the bug Something isn't working label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

axes_size should be axes_font_size in 3c_generate_qc_metrics.ipynb
3 participants