-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TMA FOV validation functions for user sanity checking #30
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…into tma_validate
… auto FOV list looks like
NOTE: now that we're running a lot of tests for certain functions randomizing order, need to start moving away from simple |
More along the lines of setting consistent random seeds, looks like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor changes only
After some thought, I've decided to do some major restructuring to the pipeline:
Let me know your thoughts @ngreenwald. |
Sure thing, if you think it'll simplify things go for it |
… mapping directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is much more clear
What is the purpose of this PR?
Closes #16 (and closes #18). Users may need some guidance as to which FOVs are the most likeliest that need remapping. This includes:
We want a way to display these to the user on the initial visualization, as well as update them on the fly when the user remaps FOVs.
How did you implement your changes
We allow the user to specify which combination of the 3 issues stated above they wish to validate in
autolabel_tma_cores.ipynb
. Each of these issues is handled in a separate validation function that builds a list of mappings that do not pass the specified tests. These non-passes will be displayed in a text box right above the slide image display.