Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with directory structure #190

Merged
merged 23 commits into from
Aug 12, 2022
Merged

Conversation

camisowers
Copy link
Contributor

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #170.

@camisowers camisowers self-assigned this Aug 2, 2022
@camisowers
Copy link
Contributor Author

let me know if there's anything I should add!

Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

srivarra added a commit that referenced this pull request Aug 10, 2022
Copy link
Contributor

@srivarra srivarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like the change of specifying the exact notebook 1_set_up_toffy.ipynb instead of just saying the first notebook.

@srivarra srivarra added the documentation Improvements or additions to documentation label Aug 10, 2022
@camisowers camisowers requested a review from ngreenwald August 10, 2022 19:32
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs some more focusing to make it maximally useful

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ngreenwald pushed a commit that referenced this pull request Aug 10, 2022
@camisowers camisowers requested a review from ngreenwald August 12, 2022 18:12
@ngreenwald ngreenwald merged commit 5e5950b into main Aug 12, 2022
@ngreenwald ngreenwald deleted the readme_dir_structure branch August 12, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain directory structure in Readme
3 participants