Check voltage #148
Merged
Check voltage #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ngreenwald
requested changes
Jul 15, 2022
ngreenwald
requested changes
Jul 18, 2022
|
yep, works on the jsons in data/tissue and I just double checked it on a run from 6-13 |
ngreenwald
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #127.
How did you implement your changes
Retrieve the detector voltage from each FOV json in the run and check whether it stays constant or changes. If not the same throughout, identify the FOV names and voltage values at each point of change in the run and print them in an error statement.
Remaining issues
If there are specific areas of your implementation that you feel need specific feedback, or if there are things you aren't sure about, please highlight them here