Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split run file #145

Merged
merged 11 commits into from
Jul 18, 2022
Merged

Split run file #145

merged 11 commits into from
Jul 18, 2022

Conversation

camisowers
Copy link
Contributor

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #144. Added a helper function to json_utils.py that splits the run json into smaller files for imaging. Also updated the notebooks to use the new function.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@camisowers camisowers requested a review from ngreenwald July 14, 2022 22:59
@camisowers camisowers self-assigned this Jul 14, 2022
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few tweaks

toffy/json_utils.py Outdated Show resolved Hide resolved
toffy/json_utils_test.py Outdated Show resolved Hide resolved
@camisowers camisowers requested a review from ngreenwald July 18, 2022 18:00
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, and did you run the notebooks to make sure there's no syntax errors?

@camisowers
Copy link
Contributor Author

camisowers commented Jul 18, 2022

Great, and did you run the notebooks to make sure there's no syntax errors?

Yes all good! @ngreenwald

@ngreenwald ngreenwald merged commit 92ea564 into main Jul 18, 2022
@ngreenwald ngreenwald deleted the split_run_file branch July 18, 2022 21:19
@camisowers camisowers added the enhancement New feature or request label Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helper function to split run json into smaller files
2 participants