-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split run file #145
Split run file #145
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few tweaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, and did you run the notebooks to make sure there's no syntax errors?
Yes all good! @ngreenwald |
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #144. Added a helper function to json_utils.py that splits the run json into smaller files for imaging. Also updated the notebooks to use the new function.