-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mph norm workflow #125
Mph norm workflow #125
Conversation
…into mph_norm_workflow
* combine metrics doesn't require bins * helper function for formatting df * refactor saving function * fov helper function * refactored top level function * pycodestyle * use median for small datasets * update notebook * close plots * fix bug in df construction * sort df by channels * outlier identification * plot outliers separately * remove outlier functionality * change outlier detection * updated docstrings * make test more robust
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. It looks like a lot of my review comments in review-nb are in the works in normalize.py
@@ -15,9 +15,10 @@ | |||
"id": "e36293c5-aa89-4029-a3fa-e8ea841bb8b5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't the sensitivity curve generation go in 4b, since it's only used there? Is the idea that putting this here will encourage people to run a sweep before data aq?
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's because it only needs to happen once per instrument, not separately for each run. So having it here means it won't be present in the notebook each time people are normalizing
@@ -15,9 +15,10 @@ | |||
"id": "e36293c5-aa89-4029-a3fa-e8ea841bb8b5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweeps aren't created in their own folder, they're just put into the main /Data folder. So you need to separately identify each FOV from the sweep, which are given the generic names. This was initially what that find_detector_sweeps
function was for, but then Erin had a couple sweeps where FOVs were missing, so it gave an error.
We could change it so that it would give a warning when an FOV is missing, rather than an error, and then ask people to list the first FOV and last FOV of their sweep and it would find the rest, but at that point it started to feel like the solution was almost as complicated as the problem. Up to you though, it would be an easy change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few aesthetic comments mostly in the notebook.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
4b_normalize_image_data
notebook which walks the user through the normalization process. This assumes the user has already constructed a tuning curve, and will allow them to easily normalize their dataCloses #37