Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find moly FOVs based on JSON file #124

Merged
merged 2 commits into from
Jun 11, 2022
Merged

find moly FOVs based on JSON file #124

merged 2 commits into from
Jun 11, 2022

Conversation

ngreenwald
Copy link
Member

@ngreenwald ngreenwald commented Jun 7, 2022

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?
Creates a helper function to identify moly FOVs in a directory. Closes #124

How did you implement your changes
Look for field in the matching JSON file that indicates it's a moly FOV

@ngreenwald ngreenwald requested a review from camisowers June 7, 2022 22:45
@ngreenwald
Copy link
Member Author

No one is coming to save you @camisowers, you're gonna have to do this one

Copy link
Contributor

@camisowers camisowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ngreenwald ngreenwald merged commit f65b103 into main Jun 11, 2022
@ngreenwald ngreenwald deleted the find_moly_fovs branch June 11, 2022 19:25
@camisowers camisowers added the enhancement New feature or request label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants