Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toffy and alpineer version conflicts #368

Closed
camisowers opened this issue May 2, 2023 · 0 comments · Fixed by #371
Closed

toffy and alpineer version conflicts #368

camisowers opened this issue May 2, 2023 · 0 comments · Fixed by #371
Assignees
Labels
bug Something isn't working

Comments

@camisowers
Copy link
Contributor

camisowers commented May 2, 2023

Please refer to our FAQ and look at our known issues before opening a bug report.

Describe the bug
The current workflow for updating the toffy_env (according to the readme) consists of pulling the latest changes and then recreating the toffy_env using environment.yml. While any recent code changes in toffy get updated in the user's toffy repo, the environment.yml file itself uses pip to install toffy and alpineer which will default to the latest releases for each. We do not currently pin the helper repos to a specific version in the conda environment like we do for poetry.

If changes are made and released to alpineer without an immediate toffy release, this will cause issues. For example, currently the stitching notebook uses an old version of the stitch_images function that doesn't account for multiple tiles, but the alpineer helper functions within it expect that logic.

Expected behavior
We should decide on a method to explicitly pin the helper repo versions (alpineer, mibi-bin-tools) that toffy uses in the conda environment.

To Reproduce
Git pull toffy, recreate the toffy_env, and try to stitch a tiled run.

@camisowers camisowers added the bug Something isn't working label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants