Multiple tiling adjustments #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4703194702
💛 - Coveralls |
srivarra
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
@camisowers Looks good! Should we make a new release after this PR gets merged in?
| # check first tile for 6x9 | ||
| prefix, expected_fovs, rows, cols = tiles[0] | ||
| assert prefix == prefix_1[:-1] and (rows, cols) == (6, 9) | ||
| assert expected_fovs == ns.natsorted( |
There was a problem hiding this comment.
natsort is such an amazing module.
Yes, definitely. |
ngreenwald
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Addresses the changes necessary to enable multiple tile stitching.
Also closes #26.
How did you implement your changes
Made the adjustments outlined in angelolab/toffy#351 and #26.
Added testing logic for multiple prefixes.
Remaining issues