Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose context to storage strategy methods. #105

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

angelnikolov
Copy link
Owner

Fixes #102
@KG3RK3N Will this work for you?

@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@f48b15e). Click here to learn what that means.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #105   +/-   ##
=========================================
  Coverage          ?   75.80%           
=========================================
  Files             ?       12           
  Lines             ?      310           
  Branches          ?       80           
=========================================
  Hits              ?      235           
  Misses            ?       60           
  Partials          ?       15           
Impacted Files Coverage Δ
common/IAsyncStorageStrategy.ts 100.00% <ø> (ø)
common/IStorageStrategy.ts 100.00% <ø> (ø)
cacheable.decorator.ts 93.33% <50.00%> (ø)
promise.cacheable.decorator.ts 90.00% <50.00%> (ø)
common/InMemoryStorageStrategy.ts 86.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48b15e...11c4afb. Read the comment docs.

@KG3RK3N
Copy link

KG3RK3N commented Apr 20, 2021

Yes, it works fine 👍

@angelnikolov angelnikolov merged commit 0361e9e into master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to cache per instance
2 participants