Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - Typo with one of the cell events (cellTapHOld -> cellTapHold) #24

Closed
aledujke opened this issue Sep 2, 2019 · 2 comments · Fixed by #25
Closed

[BUG] - Typo with one of the cell events (cellTapHOld -> cellTapHold) #24

aledujke opened this issue Sep 2, 2019 · 2 comments · Fixed by #25
Labels
bug Something isn't working waiting admin Waiting a admin interaction

Comments

@aledujke
Copy link

aledujke commented Sep 2, 2019

I am sorry for not following the template but the bug seems to be quite minor. I can submit a PR later today.

Inside of the file: src/feature/events/cell-events.ts one of the events is called cellTapHOld instead of cellTapHold. I noticed it because I am getting warnings since updating to "version": "1.2.0", of Vue-tabulator
@aledujke aledujke added bug Something isn't working waiting admin Waiting a admin interaction labels Sep 2, 2019
@angeliski
Copy link
Owner

Nice @aledujke
I will fix that soon as possible

Thank you for the issue

angeliski added a commit that referenced this issue Sep 2, 2019
@angeliski
fix(cell-events): fix cell event tapHold
efb9211 
fix #24
@angeliski angeliski mentioned this issue Sep 2, 2019
Merged
@angeliski
Copy link
Owner

Release version 1.2.1 fix that.
See you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working waiting admin Waiting a admin interaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cell-events): fix cell event tapHold angeliski/vue-tabulator
2 participants
@aledujke @angeliski