fix: capacity to update MongoDB deployment #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschneider-aneo
force-pushed
the
ts/fix-uncapacity-to-update-chart
branch
from
dcddfd8 to
c14428f
Compare
lemaitre-aneo
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the uncapacity to update the MongoDB deployment when it is already deployed, introduced by #140 .
The issue causing this bug is dependent of Kubernetes and is described here : kubernetes/kubernetes#118715
The fix consists of removing any null values or empty strings from the array passed down to the parameter
image.PullSecretsof the Helm chart.