Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dummy replace used for dependency #154

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

jdongo-aneo
Copy link
Contributor

@jdongo-aneo jdongo-aneo commented Jul 25, 2024

The resource used in the replace (data.kubernetes_secret.deployed_object_storage) needs to be removed as part of the refactoring, as there is a read from a secret that is being removed.
The PR therefore use the namespace for the dependency

@jdongo-aneo jdongo-aneo force-pushed the jd/fix-coredns-dependency branch 5 times, most recently from bb846ca to e7dbd58 Compare July 25, 2024 11:17
@jdongo-aneo jdongo-aneo marked this pull request as ready for review July 25, 2024 11:47
@jdongo-aneo jdongo-aneo force-pushed the jd/fix-coredns-dependency branch 3 times, most recently from 0dabd6a to 02d3d86 Compare July 26, 2024 08:40
@jdongo-aneo jdongo-aneo changed the title fix: remove dummy replace used for dependency fix: update dummy replace used for dependency Jul 26, 2024
@jdongo-aneo jdongo-aneo force-pushed the jd/fix-coredns-dependency branch from 02d3d86 to 33edcd7 Compare July 26, 2024 09:35
@lemaitre-aneo lemaitre-aneo merged commit 5c81c04 into main Jul 26, 2024
6 checks passed
@lemaitre-aneo lemaitre-aneo deleted the jd/fix-coredns-dependency branch July 26, 2024 09:48
lemaitre-aneo added a commit that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants