feat: add missing methods for partitions management #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Represents the data of the partitions that will be updated. | ||
| * | ||
| * ID is mandatory. | ||
| * -1 means that value will not be updated |
There was a problem hiding this comment.
I would just say negative instead of specifically -1.
The problem is that in protobuf, if a value is missing, it is set to 0...
There was a problem hiding this comment.
Ok.
But 0 is a valid number for our use case...
| repeated string parent_partition_ids = 2; /** The parent partition IDs. */ | ||
| int64 pod_reserved = 3; /** Whether the partition is reserved for pods. */ | ||
| int64 pod_max = 4; /** The maximum number of pods that can be used by sessions using the partition. */ | ||
| map<string, string> pod_configuration = 7; /** The pod configuration. */ |
There was a problem hiding this comment.
As far as I remember, map is not well supported. I think we used a list of pairs in other places.
esoubiran-aneo
suggested changes
Mar 22, 2023
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing methods for partition management in the partitions service: