Make wooden pan GroundStorable #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace pan behaviors:
```json
{ "name": "GroundStorable", "properties": { "layout": "SingleCenter" } },
{ "name": "Unplaceable", "__comment": "The ground storable obsoletes this being a block. Should be an item, but is kept a block for backwards compatibility" },
{ "name": "RightClickPickup" }
```
|
Should be also used together with #48 |
|
Could you possibly implement the IContainedMeshSource part now? |
|
@pizza2004 what for? |
I don't think this should be a vanilla feature if the contents are invisible is why. |
|
@pizza2004 Contents are invisible either way, just place it and you will see |
Are you willing to try and make them not invisible, then? |
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
survival/blocktypes/wood/pan.jsonbehaviors:{ "name": "GroundStorable", "properties": { "layout": "SingleCenter" } }, { "name": "Unplaceable", "__comment": "The ground storable obsoletes this being a block. Should be an item, but is kept a block for backwards compatibility" }, { "name": "RightClickPickup" }Pan content is not shown when in ground storage because BlockPan class doesn't have IContainedMeshSource interface implemented (I may later include it to pull request)
Fixes two issues:
anegostudios/VintageStory-Issues#1332
anegostudios/VintageStory-Issues#1174