Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly define default extensions #156

Merged
merged 2 commits into from
May 16, 2017
Merged

Explicitly define default extensions #156

merged 2 commits into from
May 16, 2017

Conversation

sapegin
Copy link
Collaborator

@sapegin sapegin commented May 16, 2017

Otherwise blocks will overwrite them instead of extending. For example I have full screen of nasty errors with typescript and devSever:

ERROR in multi (webpack)-dev-server/client?http://localhost:3423 webpack/hot/only-dev-server ./src/ui/app/index.ts
Module not found: Error: Can't resolve 'webpack/hot/only-dev-server' in '/Users/sapegin/izumi/nodejs-defaults'
 @ multi (webpack)-dev-server/client?http://localhost:3423 webpack/hot/only-dev-server ./src/ui/app/index.ts

ERROR in (webpack)-dev-server/client?http://localhost:3423
Module not found: Error: Can't resolve './socket' in '/Users/sapegin/izumi/nodejs-defaults/node_modules/webpack-dev-server/client'
 @ (webpack)-dev-server/client?http://localhost:3423 4:13-32
 @ multi (webpack)-dev-server/client?http://localhost:3423 webpack/hot/only-dev-server ./src/ui/app/index.ts

ERROR in (webpack)-dev-server/client?http://localhost:3423
Module not found: Error: Can't resolve './overlay' in '/Users/sapegin/izumi/nodejs-defaults/node_modules/webpack-dev-server/client'
 @ (webpack)-dev-server/client?http://localhost:3423 5:14-34
 @ multi (webpack)-dev-server/client?http://localhost:3423 webpack/hot/only-dev-server ./src/ui/app/index.ts

ERROR in (webpack)-dev-server/client?http://localhost:3423
Module not found: Error: Can't resolve 'webpack/hot/emitter' in '/Users/sapegin/izumi/nodejs-defaults/node_modules/webpack-dev-server/client'
 @ (webpack)-dev-server/client?http://localhost:3423 174:19-49
 @ multi (webpack)-dev-server/client?http://localhost:3423 webpack/hot/only-dev-server ./src/ui/app/index.ts

ERROR in (webpack)-dev-server/client?http://localhost:3423
Module not found: Error: Can't resolve 'strip-ansi' in '/Users/sapegin/izumi/nodejs-defaults/node_modules/webpack-dev-server/client'
 @ (webpack)-dev-server/client?http://localhost:3423 3:16-37
 @ multi (webpack)-dev-server/client?http://localhost:3423 webpack/hot/only-dev-server ./src/ui/app/index.ts

ERROR in ./~/url/url.js
Module not found: Error: Can't resolve './util' in '/Users/sapegin/izumi/nodejs-defaults/node_modules/url'
 @ ./~/url/url.js 25:11-28
 @ (webpack)-dev-server/client?http://localhost:3423
 @ multi (webpack)-dev-server/client?http://localhost:3423 webpack/hot/only-dev-server ./src/ui/app/index.ts

ERROR in ./~/querystring-es3/index.js
Module not found: Error: Can't resolve './decode' in '/Users/sapegin/izumi/nodejs-defaults/node_modules/querystring-es3'
 @ ./~/querystring-es3/index.js 3:33-52
 @ ./~/url/url.js
 @ (webpack)-dev-server/client?http://localhost:3423
 @ multi (webpack)-dev-server/client?http://localhost:3423 webpack/hot/only-dev-server ./src/ui/app/index.ts

ERROR in ./~/querystring-es3/index.js
Module not found: Error: Can't resolve './encode' in '/Users/sapegin/izumi/nodejs-defaults/node_modules/querystring-es3'
 @ ./~/querystring-es3/index.js 4:37-56
 @ ./~/url/url.js
 @ (webpack)-dev-server/client?http://localhost:3423
 @ multi (webpack)-dev-server/client?http://localhost:3423 webpack/hot/only-dev-server ./src/ui/app/index.ts

@andywer andywer merged commit 768cfca into andywer:release/1.0 May 16, 2017
@sapegin sapegin deleted the patch-2 branch May 16, 2017 09:53
@sapegin
Copy link
Collaborator Author

sapegin commented May 16, 2017

Could you please publish a new release too?

@andywer
Copy link
Owner

andywer commented May 16, 2017

Of course, but it will take an hour or so.

Bad enough that I merge PRs on the go on my iPhone, but fortunately I can't publish from it 😅

@sapegin
Copy link
Collaborator Author

sapegin commented May 16, 2017

Haha, semantic-release helps with this ;-)

@andywer
Copy link
Owner

andywer commented May 16, 2017

Published as @webpack-blocks/core v1.0.0-alpha.1

@andywer
Copy link
Owner

andywer commented May 16, 2017

Yeah, I might give semantic releasing a try some day. I just don't like the way the commit messages look ;P

@sapegin
Copy link
Collaborator Author

sapegin commented May 16, 2017

It’s all up to you — http://blog.sapegin.me/all/semantic-release ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants