Resolve nogo tautological linting error #364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nogo's static analysis finds an issue with a line in
GetListWithContext
, specifically this line:go-jira/filter.go
Line 133 in 1abf9e5
The error is
The issue seems to be that
options
is initialized to a non-nil value (&GetQueryOptions{}
), then immediately checked againstnil
despite the absence of any modifications that could make itnil
.This change just fixes this error by removing the
nil
check; if you'd prefer to keep it, feel free to just close the PR!Checklist