Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uefi-firmware: Fix GCC 14 compile issue #267

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

TanelDettenborn
Copy link

@TanelDettenborn TanelDettenborn commented Jan 15, 2025

UEFI-firmware compile fails with "missing binary operator before token "("", because "__has_builtin"-operator is not defined within gcc 14. Patching edk2-sources with existing patch. Patch is fetched from NVIDIA EDK2 repo.

Description of changes

Fetched patch checks if "__has_builtin"-operator has been defined and then uses it. Further information:

Testing

Compiled with gcc 14 and gcc 13 and both compiles.

@danielfullmer
Copy link
Collaborator

Looks reasonable. Could you correct the typo "uefi-firmaware" to "uefi-firmware" in the commit title and message?

UEFI-firmware compile fails with "missing binary operator before token "("",
because "__has_builtin"-operator is not defined within gcc 14. Patching
edk2-sources with existing patch. Patch is fetched from NVIDIA EDK2 repo.

Signed-off-by: Tanel Dettenborn <tanel@ssrc.tii.ae>
@TanelDettenborn TanelDettenborn changed the title uefi-firmaware: Fix GCC 14 compile issue uefi-firmware: Fix GCC 14 compile issue Jan 16, 2025
@TanelDettenborn
Copy link
Author

TanelDettenborn commented Jan 16, 2025

Typo fixed in the commit title and message.

@danielfullmer danielfullmer merged commit 960502d into anduril:master Jan 16, 2025
1 check failed
@danielfullmer
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants