Skip to content

Commit

Permalink
[tests.yml]: Install Cython < 1.0 Before MDAnalysis
Browse files Browse the repository at this point in the history
MDAnalysis < 3.0 seems to require Cython < 1.0 for compilation (see also
MDAnalysis/mdanalysis#4129 and
MDAnalysis/mdanalysis#3374).
  • Loading branch information
andthum committed Jul 19, 2023
1 parent a332131 commit 4da416f
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,12 @@ jobs:
restore-keys: |
${{ runner.os }}-${{ matrix.python-version }}
${{ runner.os }}
- name: "Install/Upgrade setuptools, wheel and python-dev-tools"
- name: "Install/Upgrade setuptools and wheel"
# MDAnalysis requires NumPy (>=1.16.0), even for setup.
# MDAnalysis < 3.0 requires Cython < 3.0 (see
# https://github.com/MDAnalysis/mdanalysis/pull/4129).
# MDAnalysis < 3.0 requires Cython < 1.0 (see
# https://github.com/MDAnalysis/mdanalysis/pull/4129,
# https://github.com/cython/cython/issues/3690 and
# https://github.com/MDAnalysis/mdanalysis/issues/3374).
# Without `python-dev-tools` the installation of MDAnalysis
# fails on MacOS-latest with Python 3.9 while building the wheel
# for MDAnalysis. Strangely, the MDAnalysis wheel is only build
Expand All @@ -80,9 +82,9 @@ jobs:
run: |
python -m pip install --user --upgrade setuptools wheel
python -m pip install --user --upgrade python-dev-tools
python -m pip install --user --upgrade "Cython < 3.0"
python -m pip install --user --upgrade "numpy >=1.16.0"
python -m pip install --user "Cython < 1.0"
python -m pip install --user "numpy >=1.16.0"
- name: "Test installation of this project"
run: |
python -m pip install --user --upgrade .
python -m pip install --user .
python -c "import lintf2_ether_ana_postproc"

0 comments on commit 4da416f

Please sign in to comment.