Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

DisablePNIN hardwired to debian version > stretch #349

Open
dansteen opened this issue Oct 10, 2016 · 0 comments · May be fixed by #485
Open

DisablePNIN hardwired to debian version > stretch #349

dansteen opened this issue Oct 10, 2016 · 0 comments · May be fixed by #485

Comments

@dansteen
Copy link

Hi!

First off, I wanted to thank you for your great work on this tool. It makes building images of all sorts super easy. Thanks so much!

I did run into an issue where DisablePNIN is hardcoded to depend on the release version:

if manifest.release >= stretch:
            group.append(grub.DisablePNIN)

This is probably fine in most cases, but in a case where I am using systemd from jessie-backports, I can't build working ec2 images since that doesn't get called. Would it be possible to have this hinge on a config option, perhaps with a default based on release?

Thanks!

john-pierce added a commit to john-pierce/bootstrap-vz that referenced this issue Jul 12, 2018
Fixes: andsens#349

Adds a new boolean parameter indicating weather to use PNIN or not to
the system section of the manifest.

The default, False enables tasks for extlinux and grub to pass
net.ifnames=0 biosdevnames=0 parameters to the kernel.

Previously for grub PNIN was disabled for stretch and later. This
remains the default but setting system.pnin True will allow the behavior
to be overridden. The additional parameters have no effect on earlier
releases are passed regardless. Extlinux had no prior special behavior,
it now mirrors grub.
john-pierce added a commit to john-pierce/bootstrap-vz that referenced this issue Jul 13, 2018
Fixes: andsens#349

Adds a new boolean parameter indicating weather to use PNIN or not to
the system section of the manifest.

The default, False enables tasks for extlinux and grub to pass
net.ifnames=0 biosdevnames=0 parameters to the kernel.

Previously for grub PNIN was disabled for stretch and later. This
remains the default but setting system.pnin True will allow the behavior
to be overridden. The additional parameters have no effect on earlier
releases are passed regardless. Extlinux had no prior special behavior,
it now mirrors grub.
john-pierce added a commit to john-pierce/bootstrap-vz that referenced this issue Jul 15, 2018
Fixes: andsens#349

Adds a new boolean parameter indicating weather to use PNIN or not to
the system section of the manifest.

The default, False enables tasks for extlinux and grub to pass
net.ifnames=0 biosdevnames=0 parameters to the kernel.

Previously for grub PNIN was disabled for stretch and later. This
remains the default but setting system.pnin True will allow the behavior
to be overridden. The additional parameters have no effect on earlier
releases are passed regardless. Extlinux had no prior special behavior,
it now mirrors grub.
@john-pierce john-pierce linked a pull request Jul 16, 2018 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant