-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flickering subtitles in DASH/H264 with B-frames present #288
Comments
Thanks for reporting, and for including a repro stream. I'm able to see the same issue. I've added some debug logging and it looks like this happens when we transition between
I'm still investigating exactly how the media results in this output. |
Hello, thanks for your reply. Are the any news regarding this issue? I will appreciate your help. |
I'm facing the same issue. Is there a fix yet? |
I'm currently making some fairly major changes to |
I can see 1.2.0-alpha01 is out. No mention of TextRenderer in the changelog. Are the changes still planned for 1.2.0 or rather some further release? |
I'm working on the |
The existing `Subtitle` handling code is left intact to support the legacy post-`SampleQueue` decoding path for now. This also includes full support for merging overlapping `CuesWithTiming` instances, which explains the test dump file changes, and which should resolve the following issues (if used with the decoder-before-`SampleQueue` subtitle logic added in 5d453fc): * Issue: google/ExoPlayer#10295 * Issue: google/ExoPlayer#4794 It should also help resolve Issue: #288, but that will also require some changes in the DASH module to enable pre-`SampleQueue` subtitle parsing (which should happen soon). #minor-release PiperOrigin-RevId: 571021417
The existing `Subtitle` handling code is left intact to support the legacy post-`SampleQueue` decoding path for now. This also includes full support for merging overlapping `CuesWithTiming` instances, which explains the test dump file changes, and which should resolve the following issues (if used with the decoder-before-`SampleQueue` subtitle logic added in 304dadc): * Issue: #10295 * Issue: #4794 It should also help resolve Issue: androidx/media#288, but that will also require some changes in the DASH module to enable pre-`SampleQueue` subtitle parsing (which should happen soon). #minor-release PiperOrigin-RevId: 571021417
This currently only applies to subtitles muxed into mp4 segments, and not standalone text files linked directly from the manifest. Issue: #288 #minor-release PiperOrigin-RevId: 572263764
This currently only applies to subtitles muxed into mp4 segments, and not standalone text files linked directly from the manifest. Issue: androidx/media#288 #minor-release PiperOrigin-RevId: 572263764
I've added experimental support for the new approach to subtitle parsing in DASH. This will be included in 1.2.0-rc01. You can try it out with |
The existing `Subtitle` handling code is left intact to support the legacy post-`SampleQueue` decoding path for now. This also includes full support for merging overlapping `CuesWithTiming` instances, which explains the test dump file changes, and which should resolve the following issues (if used with the decoder-before-`SampleQueue` subtitle logic added in 5d453fc): * Issue: google/ExoPlayer#10295 * Issue: google/ExoPlayer#4794 It should also help resolve Issue: #288, but that will also require some changes in the DASH module to enable pre-`SampleQueue` subtitle parsing (which should happen soon). PiperOrigin-RevId: 571021417 (cherry picked from commit 002ee05)
Media3 Version
ExoPlayer 2.18.3
Devices that reproduce the issue
All Android devices.
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Yes
Reproduction steps
Expected result
No flickering effect should be observed.
Actual result
Due to the presence of B frames in text chunks and the time offset of text segment relative to video segments:
there is an effect of flickering subtitles. When I applied the following workaround inside SubtitleOutputBuffer:
which cancels this offset, flickering effect does not occur. Anyaway, this is not long term solution for me. I will appreciate your help.
Media
https://r.dcs.redlabs.pl/dash/o2/ATM-Lab/zos/vod-test/glitch/dash_b_frames/playlist.smil
Bug Report
adb bugreport
to dev.exoplayer@gmail.com after filing this issue.The text was updated successfully, but these errors were encountered: