Update notification play/pause button with matching player state

Issue: #192 PiperOrigin-RevId: 508649684
androidx · Feb 10, 2023 · e1d12fc · e1d12fc
1 parent 574424f
commit e1d12fc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/RELEASENOTES.md b/RELEASENOTES.md
@@ -81,6 +81,8 @@
         ([#233](https://github.com/androidx/media/issues/233)).
     *   Make `QueueTimeline` more robust in case of a shady legacy session state
         ([#241](https://github.com/androidx/media/issues/241)).
+    *   Fix a bug where notification play/pause button doesn't update with
+        player state ([#192](https://github.com/androidx/media/issues/192)).
 *   Metadata:
     *   Parse multiple null-separated values from ID3 frames, as permitted by
         ID3 v2.4.

diff --git a/libraries/session/src/main/java/androidx/media3/session/MediaNotificationManager.java b/libraries/session/src/main/java/androidx/media3/session/MediaNotificationManager.java
@@ -219,9 +219,11 @@ private void updateNotificationInternal(
     if (startInForegroundRequired) {
       startForeground(mediaNotification);
     } else {
-      maybeStopForegroundService(/* removeNotifications= */ false);
+      // Notification manager has to be updated first to avoid missing updates
+      // (https://github.com/androidx/media/issues/192).
       notificationManagerCompat.notify(
           mediaNotification.notificationId, mediaNotification.notification);
+      maybeStopForegroundService(/* removeNotifications= */ false);
     }
   }