Skip to content

Commit

Permalink
feat: update native Firebase SDK versions (invertase#3663)
Browse files Browse the repository at this point in the history
Updated Firebase Android SDK BoM version to 25.3.1 (from 24.1.0) and iOS SDK to 6.25.0 (from 6.13.0).

[publish]
  • Loading branch information
russellwheatley authored May 22, 2020
1 parent 8fa6f26 commit 8d30e4e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion RNFBFirestore.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ coreVersionRequired = package['peerDependencies'][appPackage['name']]
if appPackage['sdkVersions']
firebase_sdk_version = appPackage['sdkVersions']['ios']['firebase']
else
firebase_sdk_version = '~> 6.13.0'
firebase_sdk_version = '~> 6.25.0'
end
if coreVersionDetected != coreVersionRequired
Pod::UI.warn "NPM package '#{package['name']}' depends on '#{appPackage['name']}' v#{coreVersionRequired} but found v#{coreVersionDetected}, this might cause build issues or runtime crashes."
Expand Down
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ if (findProject(':@react-native-firebase_app')) {
}
def packageJson = PackageJson.getForProject(project)
def appPackageJson = PackageJson.getForProject(appProject)
def firebaseBomVersion = appPackageJson['sdkVersions'] ? appPackageJson['sdkVersions']['android']['firebase'] : "24.1.0"
def firebaseBomVersion = appPackageJson['sdkVersions'] ? appPackageJson['sdkVersions']['android']['firebase'] : "25.3.1"
def coreVersionDetected = appPackageJson['version']
def coreVersionRequired = packageJson['peerDependencies'][appPackageJson['name']]
// Only log after build completed so log warning appears at the end
Expand Down

0 comments on commit 8d30e4e

Please sign in to comment.