-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix snackbar was covered by System navigation bar. #1697
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I0fd13d756b6967d939991422ad03c05f2e2a18ff
cdb8e78
to
23ba734
Compare
@dturner I'll add a new screenshot as soon as possible. |
Change-Id: I31feea30d14d801d224ee311fd740132246d383b
Add screenshot 3
Change-Id: If0f12500cb55daae98fd7ee0951d3d3384d26b0e # Conflicts: # app/src/testDemo/screenshots/insets_snackbar_compact_medium.png # app/src/testDemo/screenshots/insets_snackbar_expanded_expanded.png # app/src/testDemo/screenshots/insets_snackbar_medium_medium.png
Change-Id: Ib1181a3f9f6cf364794766b70b990f8616edd118
Take new screenshots.
@dturner I've added new screenshots! |
JoseAlcerreca
approved these changes
Feb 3, 2025
dturner
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
Fix snackbar was covered by System navigation bar.
Fix #1295
Supersed #1296