Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: AuthorItem pressed effect feels too narrow #18

Closed
3 tasks done
SimonMarquis opened this issue May 12, 2022 · 0 comments · Fixed by #19
Closed
3 tasks done

[Bug]: AuthorItem pressed effect feels too narrow #18

SimonMarquis opened this issue May 12, 2022 · 0 comments · Fixed by #19
Labels
bug Something isn't working

Comments

@SimonMarquis
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Is there a StackOverflow question about this issue?

  • I have searched StackOverflow

What happened?

Screenshot_20220513_001456

Relevant logcat output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@SimonMarquis SimonMarquis added the bug Something isn't working label May 12, 2022
SimonMarquis referenced this issue in SimonMarquis/nowinandroid May 12, 2022
@SimonMarquis
Move AuthorsCarousel's padding into AuthorItem
1106714 
Fixes #18
@SimonMarquis SimonMarquis mentioned this issue May 12, 2022
Merged
JolandaVerhoef pushed a commit that referenced this issue May 24, 2022
@SimonMarquis
Move AuthorsCarousel's padding into AuthorItem (#19)
0edac18 
* Move `AuthorsCarousel`'s padding into `AuthorItem`

Fixes #18

* Restore the expected layout dimensions

* Add unbounded ripple effect on `AuthorItem`

* Remove unnecessary contentAlignment

* Set LazyRow contentPadding horizontal and vertical

* Add missing import after merge
dturner pushed a commit that referenced this issue Feb 4, 2025
@Jaehwa-Noh
Merge pull request #18 from Jaehwa-Noh/fix-snackbar-take-a-screenshot
104f2a0 
Take new screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move AuthorsCarousel's padding into AuthorItem SimonMarquis/nowinandroid
1 participant
@SimonMarquis