-
Notifications
You must be signed in to change notification settings - Fork 203
Update to September release of the XR libraries #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @devbridie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the project's XR Compose libraries to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the XR Compose library to version 1.0.0-alpha07
. The code changes correctly migrate from the deprecated movable
and resizable
modifiers to the new dragPolicy
and resizePolicy
parameters on SpatialPanel
. The migration is well-executed. I've added a couple of suggestions to improve performance by memoizing policy object creation to avoid unnecessary allocations during recomposition.
dragPolicy = MovePolicy(onMove = onMove), | ||
resizePolicy = ResizePolicy( | ||
minimumSize = DpVolumeSize(0.dp, minimumHeight, 0.dp), | ||
shouldMaintainAspectRatio = true, | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve performance, it's recommended to memoize the creation of MovePolicy
and ResizePolicy
using remember
. This avoids creating new objects on every recomposition. Since onMove
and minimumHeight
can change, they should be used as keys for remember
.
For example:
val dragPolicy = remember(onMove) { MovePolicy(onMove = onMove) }
val resizePolicy = remember(minimumHeight) {
ResizePolicy(
minimumSize = DpVolumeSize(0.dp, minimumHeight, 0.dp),
shouldMaintainAspectRatio = true,
)
}
SpatialPanel(
// ...
dragPolicy = dragPolicy,
resizePolicy = resizePolicy,
)
resizePolicy = ResizePolicy(shouldMaintainAspectRatio = true), | ||
dragPolicy = MovePolicy(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To optimize performance, you should wrap the creation of ResizePolicy
and MovePolicy
with remember
. This prevents creating new policy objects on every recomposition.
For example:
val resizePolicy = remember { ResizePolicy(shouldMaintainAspectRatio = true) }
val dragPolicy = remember { MovePolicy() }
SpatialPanel(
// ...
resizePolicy = resizePolicy,
dragPolicy = dragPolicy,
)
Tested on the emulator and on-device.