Skip to content

Conversation

devbridie
Copy link
Member

Tested on the emulator and on-device.

Copy link
Contributor

Summary of Changes

Hello @devbridie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the project's XR Compose libraries to the 1.0.0-alpha07 September release. The core changes involve adapting the codebase to the updated API, specifically by replacing deprecated spatial interaction modifiers with new policy-based parameters and updating event types. This ensures the application remains compatible with the latest XR development toolkit and benefits from any improvements or new features introduced in the release.

Highlights

  • Library Version Update: The xr-compose library has been updated from version 1.0.0-alpha06 to 1.0.0-alpha07, aligning the project with the latest September release of the XR libraries.
  • API Migration for Spatial Components: Existing usage of movable and resizable modifiers on SpatialPanel has been migrated to the new dragPolicy and resizePolicy parameters, reflecting changes in the updated XR Compose API.
  • Type Renaming: The MoveEvent type used in onMove callbacks has been renamed to SpatialMoveEvent to match the new library conventions.
  • Layout Adjustments: Minor layout adjustments were made, including changing SpatialAlignment.CenterRight to SpatialAlignment.CenterEnd and applying Modifier.fillMaxSize() to a Box composable in HomeScreenSpatial.kt.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the XR Compose library to version 1.0.0-alpha07. The code changes correctly migrate from the deprecated movable and resizable modifiers to the new dragPolicy and resizePolicy parameters on SpatialPanel. The migration is well-executed. I've added a couple of suggestions to improve performance by memoizing policy object creation to avoid unnecessary allocations during recomposition.

Comment on lines +85 to +89
dragPolicy = MovePolicy(onMove = onMove),
resizePolicy = ResizePolicy(
minimumSize = DpVolumeSize(0.dp, minimumHeight, 0.dp),
shouldMaintainAspectRatio = true,
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve performance, it's recommended to memoize the creation of MovePolicy and ResizePolicy using remember. This avoids creating new objects on every recomposition. Since onMove and minimumHeight can change, they should be used as keys for remember.

For example:

val dragPolicy = remember(onMove) { MovePolicy(onMove = onMove) }
val resizePolicy = remember(minimumHeight) {
    ResizePolicy(
        minimumSize = DpVolumeSize(0.dp, minimumHeight, 0.dp),
        shouldMaintainAspectRatio = true,
    )
}
SpatialPanel(
    // ...
    dragPolicy = dragPolicy,
    resizePolicy = resizePolicy,
)

Comment on lines +101 to +102
resizePolicy = ResizePolicy(shouldMaintainAspectRatio = true),
dragPolicy = MovePolicy(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To optimize performance, you should wrap the creation of ResizePolicy and MovePolicy with remember. This prevents creating new policy objects on every recomposition.

For example:

val resizePolicy = remember { ResizePolicy(shouldMaintainAspectRatio = true) }
val dragPolicy = remember { MovePolicy() }
SpatialPanel(
    // ...
    resizePolicy = resizePolicy,
    dragPolicy = dragPolicy,
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant