Inline gradle-wrapper-validation job. #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just execute gradle-wrapper-validation in gradle-emulator-tests to save overhead of running a separate job with checkout.
TWiStErRob
reviewed
Jan 29, 2024
.github/workflows/ci.yml
Outdated
| - name: Install Java 17 | ||
| uses: actions/setup-java@v3 | ||
| with: | ||
| distribution: 'zulu' | ||
| java-version: '17' | ||
| - name: Gradle wrapper validation | ||
| uses: gradle/wrapper-validation-action@v1 |
There was a problem hiding this comment.
Suggested change
| uses: gradle/wrapper-validation-action@v1 | |
| uses: gradle/wrapper-validation-action@v2 |
https://github.com/gradle/wrapper-validation-action/releases/tag/v2.0.0-rc.1 released few minutes ago.
There was a problem hiding this comment.
isn't it safer to use only stable versions?
There was a problem hiding this comment.
Up to you, it's only minor and patch bumps apart from the Node 20 change.
I wouldn't expect issues from this action, Gradle's RCs are pretty stable usually and final release won't require any changes.
Some examples where it's working fine:
ReactiveCircus/android-emulator-runner#374
junit-pioneer/junit-pioneer#804
TWiStErRob
reviewed
Jan 29, 2024
| build: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 20 | ||
| steps: | ||
| - name: Check out repository code | ||
| uses: actions/checkout@v3 | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
test: job's checkout is still v3 I think, see warnings:
https://github.com/android/android-test/actions/runs/7702474927?pr=2129
brettchabot
force-pushed
the
inline_gradle_wrapper
branch
from
bbd6bb3 to
1dd2af5
Compare
copybara-service
bot
closed this pull request by merging all changes
into
main
in
cf3dfe9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just execute gradle-wrapper-validation in gradle-emulator-tests to save overhead of running a separate job with checkout.
Also update to actions/checkout@v4