Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Get Player Info #63

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Add Get Player Info #63

merged 3 commits into from
Jan 7, 2025

Conversation

andrewsayre
Copy link
Owner

@andrewsayre andrewsayre commented Jan 7, 2025

Description:

Implements the Get Player Info command and ability to refresh the data of a player.

New

Heos class:

  • Added get_player_info function to retrieve a specific player and optionally refresh and update an existing instance.

HeosPlayer class:

  • Added parameter refresh_base_info: bool = True to refresh to optionally pull the latest player information, such as name.
  • Added group_id field to represent the group reference the player is a member of, otherwise None.

Related issue (if applicable): link: #62

Checklist:

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added/updated. No exclusions in .coveragerc permitted.
  • README.MD updated (if necessary)

@andrewsayre andrewsayre linked an issue Jan 7, 2025 that may be closed by this pull request
7 tasks
@andrewsayre andrewsayre merged commit 624cc5b into dev Jan 7, 2025
5 checks passed
@andrewsayre andrewsayre deleted the feature_get_player_info branch January 7, 2025 20:37
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (184a85b) to head (fbbd93c).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #63   +/-   ##
=======================================
  Coverage   99.69%   99.70%           
=======================================
  Files          17       17           
  Lines        1640     1670   +30     
=======================================
+ Hits         1635     1665   +30     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsayre andrewsayre mentioned this pull request Jan 7, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add remaining Player commands
2 participants