Update incorrect project name in README #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference to stardardrb-linter-action is incorrect.
andrewmcodes
approved these changes
Dec 6, 2019
There was a problem hiding this comment.
Thank you @martinemde! I have a lot of changes I need to make on this that I haven’t gotten around to yet bc I haven’t heard of anyone using this but if you are I can bump those improvements up on my todo list.
|
Nice. Does github actions tell you if anyone is using it? It's one of only a few github actions for ruby, so I'm suprised more people aren't using it. |
|
@martinemde they do not unfortunately. I know my rubocop action is much more popular only bc of Issues and PR’s. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Description
Reference to stardardrb-linter-action is incorrect.
Why should this be added
I initially copied the first line in the readme a few weeks ago and gave up when it didn't work. I didn't notice the project name was wrong and just thought the action was broken. I decided to try again today and it works with the correct name.
Checklist