Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: library sync errors for games w/o a source #663

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix: library sync errors for games w/o a source #663

merged 2 commits into from
Dec 9, 2024

Conversation

andrew-codes
Copy link
Owner

Includes better logging of errors and ability to match the number of sent items and number of processed items between the plugin and the app.

Closes #659

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 59.72%. Comparing base (10f7267) to head (aac5e90).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
apps/playnite-web/src/server/mqttUpdater/index.ts 50.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
- Coverage   59.89%   59.72%   -0.18%     
==========================================
  Files          98       98              
  Lines        1915     1929      +14     
  Branches      420      433      +13     
==========================================
+ Hits         1147     1152       +5     
- Misses        713      717       +4     
- Partials       55       60       +5     
Flag Coverage Δ
component-tests 36.04% <ø> (ø)
e2e-tests 72.22% <100.00%> (-0.13%) ⬇️
unit-tests 9.35% <23.07%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrew-codes andrew-codes merged commit ecc60e2 into main Dec 9, 2024
8 checks passed
@andrew-codes andrew-codes deleted the 659 branch December 9, 2024 14:11
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
## [10.0.2](v10.0.1...v10.0.2) (2024-12-10)

### Bug Fixes

* library sync errors for games w/o a source ([#663](#663)) ([ecc60e2](ecc60e2)), closes [#659](#659)
* remember me auth sessions expires in 1 year ([#666](#666)) ([e100330](e100330)), closes [#546](#546)
* signout works as expected ([#665](#665)) ([b4e0197](b4e0197)), closes [#662](#662)
Copy link

🎉 This PR is included in version 10.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

Source being null prevents library sync
1 participant