Allow configuration via DB URL #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with MongoDB Atlas and similar services
andrew-codes
requested changes
May 28, 2024
- Update getDbClient function to accept either DbConnectionString or DbConnectionOptions - Ensure MongoClient initialization based on the type of connection options provided
andrew-codes
approved these changes
May 31, 2024
andrew-codes
merged commit bfb5e5a
into
andrew-codes:release-3.2.x
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andrew-codes
Add support for database URLs in getDbClient to enhance compatibility with MongoDB Atlas and similar services
Refactored the getDbClient function to accept a url parameter in the DbConnectionOptions. This change enables the use of MongoDB connection strings, which are necessary for services like MongoDB Atlas that use different connection schemas. By allowing the use of a full URL, we ensure better flexibility and compatibility with various database hosting services, simplifying the connection process and improving maintainability.