fix: inability to install extension #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newtonsoft.json dll is explicitly ignored by the Playnite Toolbox utility which is used to pack the extension. For this reason, packaged extensions are installed without this dll and throw an error when Playnite is run. Although Playnite SDK provides a serialization utility, it does not allow configuration of casing (camel case). For this reason, System.Text.Json is used as Newtonsoft's replacement. Fixes #230
andrew-codes
added a commit
that referenced
this pull request
May 6, 2024
Newtonsoft.json dll is explicitly ignored by the Playnite Toolbox utility which is used to pack the extension. For this reason, packaged extensions are installed without this dll and throw an error when Playnite is run. Although Playnite SDK provides a serialization utility, it does not allow configuration of casing (camel case). For this reason, System.Text.Json is used as Newtonsoft's replacement. Fixes #230
andrew-codes
added a commit
that referenced
this pull request
May 6, 2024
Newtonsoft.json dll is explicitly ignored by the Playnite Toolbox utility which is used to pack the extension. For this reason, packaged extensions are installed without this dll and throw an error when Playnite is run. Although Playnite SDK provides a serialization utility, it does not allow configuration of casing (camel case). For this reason, System.Text.Json is used as Newtonsoft's replacement. Fixes #230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newtonsoft.json dll is explicitly ignored by the Playnite Toolbox utility which is used to pack the extension. For this reason, packaged extensions are installed without this dll and throw an error when Playnite is run.
Although Playnite SDK provides a serialization utility, it does not allow configuration of casing (camel case). For this reason, System.Text.Json is used as Newtonsoft's replacement.
Fixes #230