Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform icons are missing #473

Closed
andrew-codes opened this issue Aug 13, 2024 · 2 comments · Fixed by #474
Closed

Platform icons are missing #473

andrew-codes opened this issue Aug 13, 2024 · 2 comments · Fixed by #474
Assignees
@andrew-codes
Labels
app:playnite-web Web app bug Something isn't working released

Comments

@andrew-codes
Copy link
Owner

Platform icons are retrieved by name from /platforms/{name}. The platforms directory is served from public/assets. Note that the platforms asset directory are never copied to the public/assets directory when packaging the site.
@andrew-codes andrew-codes added bug Something isn't working app:playnite-web Web app labels Aug 13, 2024
@andrew-codes andrew-codes self-assigned this Aug 13, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🗃️ in Playnite-Web Aug 13, 2024
andrew-codes added a commit that referenced this issue Aug 13, 2024
@andrew-codes
fix(ui): 🐛 platform icons show properly in UI
a2555a8 
Platform assets are now copied to the deployed `public/assets`
directory.

✅ Closes: #473
@andrew-codes andrew-codes mentioned this issue Aug 13, 2024
Merged
andrew-codes added a commit that referenced this issue Aug 13, 2024
@andrew-codes
fix(ui): 🐛 platform icons show properly in UI (#474)
c1a69b8 
Platform assets are now copied to the deployed `public/assets`
directory.

✅ Closes: #473
@github-project-automation github-project-automation bot moved this from Needs Triage 🗃️ to Done ✅ in Playnite-Web Aug 13, 2024
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 5.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@andrew-codes andrew-codes reopened this Aug 13, 2024
@github-project-automation github-project-automation bot moved this from Done ✅ to Ready 📝 in Playnite-Web Aug 13, 2024
@github-project-automation github-project-automation bot moved this from Ready 📝 to Done ✅ in Playnite-Web Aug 13, 2024
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 5.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-codes andrew-codes

Labels
app:playnite-web Web app bug Something isn't working released
Projects
Playnite-Web
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): 🐛 platform icons show properly in UI andrew-codes/playnite-web
1 participant
@andrew-codes