Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish GitHub runner to ghcr.io and its source code is within this repo #331

Closed
2 tasks done
andrew-codes opened this issue May 28, 2024 · 0 comments · Fixed by #333
Closed
2 tasks done

Publish GitHub runner to ghcr.io and its source code is within this repo #331

andrew-codes opened this issue May 28, 2024 · 0 comments · Fixed by #333
Assignees
@andrew-codes
Labels
chore Technical maintenance or providing no immediate user-facing value. released
Milestone
v3.2.0

Comments

@andrew-codes
Copy link
Owner

andrew-codes commented May 28, 2024 •
edited
Loading

Sometimes contributors will need to troubleshoot their PR in the context of the runner. This is especially true for changes that impact workflow definitions. To make the runner image available, its source code should exist in this project, and it should push images to ghcr.io. Additionally, the local runners should pull from ghcr.io.

  • Runner image is an Nx application in the playnite-web repo
  • Runner image is built as part of the normal workflow
@andrew-codes andrew-codes added the chore Technical maintenance or providing no immediate user-facing value. label May 28, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🗃️ in Playnite-Web May 28, 2024
@andrew-codes andrew-codes added this to the v3.2.0 milestone May 28, 2024
@andrew-codes andrew-codes self-assigned this May 28, 2024
@andrew-codes andrew-codes mentioned this issue May 28, 2024
Merged
andrew-codes added a commit that referenced this issue May 28, 2024
@andrew-codes
chore: gh runner is in repo (#333)
6b63ccf 
Closes #331 
Closes #321
@github-project-automation github-project-automation bot moved this from Needs Triage 🗃️ to Done ✅ in Playnite-Web May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-codes andrew-codes

Labels
chore Technical maintenance or providing no immediate user-facing value. released
Projects
Playnite-Web
Archived in project
Milestone
v3.2.0
Development

Successfully merging a pull request may close this issue.

chore: gh runner is in repo andrew-codes/playnite-web
1 participant
@andrew-codes