Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated return statement #2

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Conversation

Akkii4
Copy link
Contributor

@Akkii4 Akkii4 commented Aug 18, 2023

Fixed the statement about assembly return second parameter (size)

README.md Outdated
return(0x80, 0xc0)
// return the data from slot 0x80 and 0x40 is size of the return data
return(0x80, 0x40)
// return(0x80, 0xc0) // returns data of size 0xc0 (which is bigger than expected)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete this line altogether.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, please review

Copy link
Owner

@andreitoma8 andreitoma8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks for the contribution!

@Akkii4 Akkii4 requested a review from andreitoma8 August 18, 2023 15:09
@andreitoma8 andreitoma8 merged commit 38aa014 into andreitoma8:master Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants