fix #34, record abandoned reason for conflicting entry logs #36
Conversation
There was a problem hiding this comment.
The functional changes look good. I think we need to work on the naming. Any ideas other than ConflictingEntry? The word Entry in there is redundant.
Also, let's reword the explanatory comment in the enum and use triple slash /// instead of // in TransitionAbandonedReason comments so that they show up in rust docs.
little_raft/src/state_machine.rs
Outdated
| @@ -26,6 +26,10 @@ pub enum TransitionAbandonedReason { | |||
| // NotLeader transitions have been abandoned because the replica is not | |||
| // the cluster leader. | |||
| NotLeader, | |||
|
|
|||
| // ConflictingEntry entry logs in followers that are inconsistent with the | |||
| // leader's. | |||
There was a problem hiding this comment.
_name_ uncommitted transitions are abandoned because they don't match the consensus achieved by the majority of the cluster.
How about |
|
|
|
@andreev-io Fixed. |
|
Thank you for your contributions @suzaku! |
No description provided.