Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PaginateService and update dependencies #8

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Add PaginateService and update dependencies #8

merged 5 commits into from
Feb 9, 2024

Conversation

andrecego
Copy link
Owner

This pull request implements listing for the Candidates endpoint.

Aditional features:

  • Add 'oj' gem for JSON serialization performance.
  • Updating the 'rubocop' configs and lint.
  • Adds the PaginateService which is responsible for paginating a relation and returning metadata about the pagination

@andrecego andrecego self-assigned this Feb 9, 2024
@andrecego andrecego added documentation Improvements or additions to documentation enhancement New feature or request backend Change on the backend labels Feb 9, 2024
andrecego
andrecego commented Feb 9, 2024
View reviewed changes
Gemfile
gem 'mysql2', '~> 0.5'
gem 'oj'
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance optimizations for json serialization: https://github.com/ohler55/oj?tab=readme-ov-file#performance-comparisons

@andrecego andrecego merged commit 14a4d6c into main Feb 9, 2024
3 checks passed
@andrecego andrecego deleted the feat/add-candidates-list branch February 9, 2024 20:19
@andrecego andrecego mentioned this pull request Feb 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andrecego andrecego

Labels
backend Change on the backend documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrecego