Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the errors key first in the response JSON #131

Merged

Conversation

anmonteiro
Copy link
Contributor

@anmonteiro anmonteiro commented Dec 9, 2018

According to the Response Formatsection of the GraphQL Spec:

When errors is present in the response, it may be helpful for it to
appear first when serialized to make it more clear when errors are
present in a response during debugging.

refs #119

According to the `Response Format`
[section](https://facebook.github.io/graphql/June2018/#sec-Response-Format)
of the GraphQL Spec:

> When errors is present in the response, it may be helpful for it to
appear first when serialized to make it more clear when errors are
present in a response during debugging.

refs andreas#119
@andreas andreas merged commit 9b82a9b into andreas:master Dec 10, 2018
@andreas
Copy link
Owner

andreas commented Dec 10, 2018

Thanks, nice improvement! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants