Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add rationale codeowner + improv contrib #49

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

andreacfromtheapp
Copy link
Owner

@andreacfromtheapp andreacfromtheapp commented Aug 26, 2024

Pull request template

Before submitting a pull request (check all applicable)

  • Read the Contributing Guide (required)
  • Read the Code Of Conduct (required)
  • Include tests for your changes (if necessary)
  • pre-commit run --all-files returns no issues (required)
  • Spell-check with cargo spellcheck check (required)
  • Update the spellcheck.dic (if necessary)
  • Update any related documentation and include any relevant screenshots
  • Use Conventional
    Commits
    (required)

Pull request type (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation

Description

Motivation

Solution

Additional context

Related Tickets & Documents

  • Related discussion #
  • Related issue #
  • Closes issue #

Instructions, screenshots, recordings

Please replace this line with instructions on how to test your changes. A note
on the devices and systems this has been tested on, as well as any relevant
images for UI changes.

Accessibility checklist

If your PR includes UI changes, please use this checklist:

  • Keyboard operability supported?
  • Color contrast tested?

Added/updated tests

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details
  • I need help with writing tests

Signed-off-by: gacallea <3269984+gacallea@users.noreply.github.com>
@andreacfromtheapp andreacfromtheapp merged commit acd09e2 into main Aug 26, 2024
14 checks passed
@andreacfromtheapp andreacfromtheapp deleted the rationnnn branch August 26, 2024 14:35
andreacfromtheapp added a commit that referenced this pull request Sep 27, 2024
## 🤖 New release
* `freesound-credits`: 0.2.15 -> 0.2.16 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.2.16](v0.2.15...v0.2.16)

### ⚙️ Miscellaneous Tasks

- Improved credit_sound + add test for non lowercase file name
([#51](#51)) -
([afd2446](afd2446))
- Add rationale codeowner + improv contrib
([#49](#49)) -
([acd09e2](acd09e2))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant