Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix typescript 2.9 errors #36

Merged
merged 1 commit into from
Apr 25, 2018
Merged

feat: fix typescript 2.9 errors #36

merged 1 commit into from
Apr 25, 2018

Conversation

andnp
Copy link
Owner

@andnp andnp commented Apr 25, 2018

Typescript 2.9 makes keyof return string | number | symbol instead
of simply string. This is a breaking change with TS, meaning it broke
several methods that relied on keyof returning a string within ST.

Typescript 2.9 makes `keyof` return `string | number | symbol` instead
of simply `string`. This is a breaking change with TS, meaning it broke
several methods that relied on keyof returning a string within ST.
@andnp
Copy link
Owner Author

andnp commented Apr 25, 2018

PR that broke the build

@andnp andnp merged commit 391cd19 into master Apr 25, 2018
@andnp andnp deleted the ts2.9 branch April 25, 2018 22:41
@andnp
Copy link
Owner Author

andnp commented Apr 25, 2018

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant