Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: For large lists,
nn.symdel
can take an extended amount of time. It would be helpful to see the progress of the algorithm.Solution: Add an optional
tqdm
progress bar to the main loop of_symdel_lookup
.Changes:
tqdm
dependencyprogress
argument to bothsymdel
andsymdel_lookup
enumerate(seq2)
ifprogress=True
, by default it is false and behaviour is unchangedtqdm.auto.tqdm
to support both CLI and notebooksprogress
functionalityLet me know if you'd like any changes!