Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symdel progress #46

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Symdel progress #46

merged 3 commits into from
Jul 31, 2024

Conversation

mvcowley
Copy link
Contributor

@mvcowley mvcowley commented Jul 26, 2024

Issue: For large lists, nn.symdel can take an extended amount of time. It would be helpful to see the progress of the algorithm.

Solution: Add an optional tqdm progress bar to the main loop of _symdel_lookup.

Changes:

  • Add tqdm dependency
  • Add new progress argument to both symdel and symdel_lookup
  • Add logic to wrap enumerate(seq2) if progress=True, by default it is false and behaviour is unchanged
  • Uses tqdm.auto.tqdm to support both CLI and notebooks
  • Add unit test for progress functionality

Let me know if you'd like any changes!

setup.py Show resolved Hide resolved
Copy link
Owner

@andim andim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Owner

@andim andim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR. Thanks Matt.

@andim andim merged commit 8288a15 into andim:main Jul 31, 2024
1 check passed
@mvcowley
Copy link
Contributor Author

No worries! Would you be happy to push a minor release to PyPi so Decombinator can use the new feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants