Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pc tests #31

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Improve pc tests #31

merged 6 commits into from
Mar 18, 2024

Conversation

yutanagano
Copy link
Collaborator

@yutanagano yutanagano commented Mar 18, 2024 •
edited
Loading

  • Better tests for pc and pcDelta have been implemented.
    • Make use of dummy TCR data df provided in tests/resources to test function behaviour with dataframe inputs
  • Deprecate/remove old test file.

close #28
close #29

This was linked to issues Mar 18, 2024
test pc #28
Closed
test pcDelta #29
Closed
@yutanagano yutanagano requested a review from andim March 18, 2024 20:05
andim
andim approved these changes Mar 18, 2024
View reviewed changes
Copy link
Owner

@andim andim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding this more detailed tests.

@andim andim merged commit d6aa2a7 into main Mar 18, 2024
2 checks passed
@yutanagano yutanagano deleted the improve_pc_tests branch March 18, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andim andim andim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test pcDelta test pc
2 participants
@yutanagano @andim