Implements take method()

[stephandesouza]

The current limit implementation introduced at #621 does it on the wrong manner, and totally different as expected from orderBy method().

To prevent BC I implemented Eloquent's limit as take (take is an alias to limit) and adjusted the limit description.

This PR also fixes #726 and #426

[stephandesouza]

@bsormagec can you help with this?

We're using since suggested here and no problems found with both methods.

[juliomotol]

💥 Breaking change, in one of our project we were doing $repository->limit(10)->get().

After updating to 2.7.6, it now throws Too few arguments to function Illuminate\Support\Collection::get(), 0 passed in /home/deploy/www/vivamusicgroup/app/Http/Composers/Backend/DashboardComposer.php on line 85 and at least 1 expected.

[stephandesouza]

Downgrading to 2.7.5 what object is returned when using $repository->limit(10)?

I don't get how parserResult() is returning a different object there.

[juliomotol]

Downgrading to 2.7.5 what object is returned when using $repository->limit(10)

It returns a Illuminate/Database/Eloquent/Builder.

I don't get how parserResult() is returning a different object there.

I'm not quite sure either, I haven't used and Presenters in my projects yet...

l5-repository/src/Prettus/Repository/Eloquent/BaseRepository.php

Lines 1074 to 1095 in ad55bf2

	public function parserResult($result)
	{
	if ($this->presenter instanceof PresenterInterface) {
	if ($result instanceof Collection || $result instanceof LengthAwarePaginator) {
	$result->each(function ($model) {
	if ($model instanceof Presentable) {
	$model->setPresenter($this->presenter);
	}
	return $model;
	});
	} elseif ($result instanceof Presentable) {
	$result = $result->setPresenter($this->presenter);
	}
	if (!$this->skipPresenter) {
	return $this->presenter->present($result);
	}
	}
	return $result;
	}

[stephandesouza]

Oh, i see... without presenters parseResult parses nothing, and only return the builder. The old limit method causes this mislead.

I don’t know how can this be fixed, for me this is a bug on parseResult. @bsormagec can you help us?

@juliomotol Is easy for you adapt to use ‘all’ where ‘get’ is used with limit?

$repository->limit(10)->all()

[juliomotol]

The breaking change was that the query was concluded when the all() method was called.

Prior to this commit, we still needed to chain the all()/get() after limit().

We've already updated all the repositories to no longer chain all()/get() after limit().

These comments are just to notify you that this is a breaking change in our case when we upgraded to the latest version.

@andersao @bsormagec