Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add focus and autofocus #28

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

GoldAndLink
Copy link
Contributor

@GoldAndLink GoldAndLink commented Nov 30, 2023

For several use case we might need to not autofocus on the input right away. This PR allow the use of the prop autoFocus.
The PR also exposes the following function with ref:
| focus | () => void; | Focus of the OTP input. |

@anday013
Copy link
Owner

@GoldAndLink Hi, thank you for your contribution! May I ask you to briefly describe the feature and its use case in the PR description?

@GoldAndLink
Copy link
Contributor Author

Sure, sorry for popping out of nowhere

@anday013
Copy link
Owner

anday013 commented Dec 4, 2023

@GoldAndLink thank you! Are you able to add tests for this feature? Also, please set autoFocus as true by default, cuz the prev. versions of library hold this condition, so we do not hit any breaking change in the lib

@anday013 anday013 merged commit ce14be1 into anday013:main Dec 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants